Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/backup_global_settings - add new resource #16475

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16343

Release note for CHANGELOG:

resource_aws_backup_global_settings - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsBackupGlobalSettings_basic'
--- PASS: TestAccAwsBackupGlobalSettings_basic (104.31s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner November 28, 2020 10:48
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/backup Issues and PRs that pertain to the backup service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 28, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Nov 28, 2020
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN   TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT  TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (31.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.167s

@bobziuchkovski
Copy link
Contributor

Curious if this one is going to be merged soon?

@ewbankkit
Copy link
Contributor

@DrFaust92 Is this ready for re-review?

@DrFaust92
Copy link
Collaborator Author

@ewbankkit Yes! thank you 👍

@ewbankkit ewbankkit self-assigned this Jan 15, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN   TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT  TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (29.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.997s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN   TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT  TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (30.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.249s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN   TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT  TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (20.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.499s

@breathingdust breathingdust merged commit 1889f69 into hashicorp:master Jan 18, 2021
breathingdust added a commit that referenced this pull request Jan 18, 2021
@breathingdust breathingdust added this to the v3.25.0 milestone Jan 18, 2021
@ghost
Copy link

ghost commented Jan 22, 2021

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2021
@DrFaust92 DrFaust92 deleted the r/backup_global_settings branch April 15, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/backup Issues and PRs that pertain to the backup service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Backup cross-account backup feature
4 participants